Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename kafka topic prefix config #1081

Merged
merged 3 commits into from
Feb 21, 2024
Merged

Rename kafka topic prefix config #1081

merged 3 commits into from
Feb 21, 2024

Conversation

sahibamittal
Copy link
Collaborator

@sahibamittal sahibamittal commented Feb 19, 2024 •
edited

Closes #1080

nscuro
nscuro requested changes Feb 21, 2024
View reviewed changes
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few more places where API_TOPIC_PREFIX is still being used:

image

Unfortunately merging of another PR also caused a small merge conflict, please rebase with main to resolve.

@nscuro nscuro added this to the 0.4.0 milestone Feb 21, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 21, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nscuro nscuro merged commit 6db29da into main Feb 21, 2024
12 checks passed
@nscuro nscuro deleted the issue-1080-rename-kafka-topic-prefix branch February 21, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nscuro nscuro nscuro approved these changes

Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Rename api.topic.prefix to kafka.topic.prefix
2 participants
@sahibamittal @nscuro