Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix generate-bom-testdata.sh failing due to removed ZAP image #1109

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Feb 29, 2024

ZAP is no longer an OWASP project, so their images have been removed from the owasp Docker Hub organization.

Also update the script to use a Trivy container instead of a local installation. Avoids the overhead of having to install Trivy.

ZAP is no longer an OWASP project, so their images have been removed from the `owasp` Docker Hub organization.

Also update the script to use a Trivy container instead of a local installation. Avoids the overhead of having to install Trivy.

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro added the defect Something isn't working label Feb 29, 2024
@nscuro nscuro added this to the 0.4.0 milestone Feb 29, 2024
Copy link

sonarcloud bot commented Feb 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@VinodAnandan VinodAnandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nscuro nscuro merged commit 8b0ac96 into main Feb 29, 2024
11 checks passed
@nscuro nscuro deleted the fix-testdata-gen-script branch February 29, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants