Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removed usage of mockserver #1119

Merged
merged 4 commits into from
Mar 5, 2024
Merged

removed usage of mockserver #1119

merged 4 commits into from
Mar 5, 2024

Conversation

mehab
Copy link
Collaborator

@mehab mehab commented Mar 4, 2024 •
edited

Closes #993

@mehab
removed usage of mockserver
1f0b36f 
Signed-off-by: mehab <meha.bhargava@citi.com>
@mehab
adding wiremock dependency
b736701 
Signed-off-by: mehab <meha.bhargava@citi.com>
@mehab
adding wiremock dependency
751cb16 
Signed-off-by: mehab <meha.bhargava@citi.com>
@mehab mehab marked this pull request as ready for review March 4, 2024 18:39
nscuro
nscuro reviewed Mar 5, 2024
View reviewed changes
Copy link
Member

@nscuro nscuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, thanks!

Just a minor question about the new jakarta.ws.rs-api dependency.

commons/pom.xml Outdated Show resolved Hide resolved
@nscuro nscuro added this to the 0.4.0 milestone Mar 5, 2024
@mehab
pr review
4203e8b 
Signed-off-by: mehab <meha.bhargava@citi.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 5, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nscuro nscuro merged commit 509e78c into main Mar 5, 2024
11 checks passed
@nscuro nscuro deleted the feature/removeMockServer branch March 5, 2024 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nscuro nscuro nscuro approved these changes

@sahibamittal sahibamittal Awaiting requested review from sahibamittal

Assignees
No one assigned
Labels
technical debt
Projects
None yet
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

Replace usages of MockServer with WireMock
2 participants
@mehab @nscuro