Fix Maven repo meta analysis failing with native image #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running the repository meta analyzer as native images, it would fail to analyze Maven components with the following stacktrace: ``` java.util.MissingResourceException: Could not load any resource bundle by com.sun.org.apache.xml.internal.res.XMLErrorResources at java.xml@17.0.5/jdk.xml.internal.SecuritySupport.lambda$getResourceBundle$5(SecuritySupport.java:280) at java.base@17.0.5/java.security.AccessController.executePrivileged(AccessController.java:168) at java.base@17.0.5/java.security.AccessController.doPrivileged(AccessController.java:318) at java.xml@17.0.5/jdk.xml.internal.SecuritySupport.getResourceBundle(SecuritySupport.java:273) at java.xml@17.0.5/jdk.xml.internal.SecuritySupport.getResourceBundle(SecuritySupport.java:262) at java.xml@17.0.5/com.sun.org.apache.xml.internal.res.XMLMessages.createXMLMessage(XMLMessages.java:84) at java.xml@17.0.5/com.sun.org.apache.xml.internal.utils.ObjectPool.getInstance(ObjectPool.java:144) at java.xml@17.0.5/com.sun.org.apache.xml.internal.utils.StringBufferPool.get(StringBufferPool.java:45) at java.xml@17.0.5/com.sun.org.apache.xml.internal.dtm.ref.dom2dtm.DOM2DTM.getStringValue(DOM2DTM.java:822) at java.xml@17.0.5/com.sun.org.apache.xpath.internal.objects.XNodeSet.getStringFromNode(XNodeSet.java:219) at java.xml@17.0.5/com.sun.org.apache.xpath.internal.objects.XNodeSet.str(XNodeSet.java:282) at java.xml@17.0.5/com.sun.org.apache.xpath.internal.jaxp.XPathImplUtil.getResultAsType(XPathImplUtil.java:151) at java.xml@17.0.5/com.sun.org.apache.xpath.internal.jaxp.XPathExpressionImpl.eval(XPathExpressionImpl.java:81) at java.xml@17.0.5/com.sun.org.apache.xpath.internal.jaxp.XPathExpressionImpl.evaluate(XPathExpressionImpl.java:89) at org.acme.repositories.MavenMetaAnalyzer.analyze(MavenMetaAnalyzer.java:96) at org.acme.repositories.MavenMetaAnalyzer_ClientProxy.analyze(Unknown Source) ``` The necessary resource bundles are defined in `quarkus-jaxb`. Including `quarkus-jaxb` as dependency resolves the issue, and analysis is taking place as expected. https://github.com/quarkusio/quarkus/blob/2.15.3.Final/extensions/jaxp/deployment/src/main/java/io/quarkus/jaxp/deployment/JaxpProcessor.java#L38 Signed-off-by: nscuro <nscuro@protonmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
mehab
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running the repository meta analyzer as native images, it would fail to analyze Maven components with the following stacktrace:
The necessary resource bundles are defined in
quarkus-jaxb. Includingquarkus-jaxbas dependency resolves the issue, and analysis is taking place as expected.https://github.com/quarkusio/quarkus/blob/2.15.3.Final/extensions/jaxp/deployment/src/main/java/io/quarkus/jaxp/deployment/JaxpProcessor.java#L38