Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable database features for mirror service #298

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Feb 1, 2023

The service does not need nor use database access, yet it still tries to connect to one and creates a connection pool. This is happening because Quarkus auto-detects entity and repository classes from the commons module, making the assumption that we want to use Hibernate.

The service does not need nor use database access, yet it still tries to connect to one and creates a connection pool. This is happening because Quarkus auto-detects entity and repository classes from the `commons` module, making the assumption that we want to use Hibernate.

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro added enhancement New feature or request domain/vuln-mirroring labels Feb 1, 2023
Copy link
Collaborator

@VinodAnandan VinodAnandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nscuro nscuro merged commit 02c67ed into main Feb 1, 2023
@nscuro nscuro deleted the remove-db-access-for-mirror-service branch February 1, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants