Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable SonarCloud #324

Merged
merged 4 commits into from
Feb 11, 2023
Merged

Re-enable SonarCloud #324

merged 4 commits into from
Feb 11, 2023

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Feb 10, 2023

Signed-off-by: Niklas nscuro@protonmail.com

Signed-off-by: Niklas <nscuro@protonmail.com>
@nscuro nscuro added enhancement New feature or request ci labels Feb 10, 2023
Signed-off-by: Niklas <nscuro@protonmail.com>
Copy link
Collaborator

@VinodAnandan VinodAnandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

VinodAnandan
VinodAnandan previously approved these changes Feb 10, 2023
@nscuro
Copy link
Member Author

nscuro commented Feb 10, 2023

@VinodAnandan Please don't merge yet, let's first get the analysis to work.

Signed-off-by: Niklas <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Feb 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nscuro nscuro marked this pull request as ready for review February 11, 2023 17:21
Copy link
Collaborator

@VinodAnandan VinodAnandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nscuro nscuro merged commit 6df1437 into main Feb 11, 2023
@nscuro nscuro deleted the nscuro-patch-1 branch February 19, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants