Add protobuf serializers and schemas for vulnerability analysis domain #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
mehab
reviewed
Feb 20, 2023
Signed-off-by: nscuro <nscuro@protonmail.com>
|
Kudos, SonarCloud Quality Gate passed! |
mehab
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an initial draft of Protobuf schemas for use with the vulnerability analyzer, along with some serialization logic.
Custom serialization logic was needed, as the official Protobuf serializers require use of a schema registry, which we decided to not use for now.
Both serialization logic and generated Java classes reside in the new
protomodule, which is intended to be used by modules within the Hyades project. Applications living outside this repo are intended to pick the.protofiles they're interested in (e.g.vuln-analysis_v1.proto), and generate the corresponding code by themselves.In later PRs, existing code in
vulnerability-analyzerandmirror-servicewill be updated to use these schemas.Relates to #244