Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metrics trial #351

Merged
merged 33 commits into from
Mar 7, 2023
Merged

Metrics trial #351

merged 33 commits into from
Mar 7, 2023

Conversation

VithikaS
Copy link
Collaborator

@VithikaS VithikaS commented Mar 1, 2023

This PR is to calculate Project and Portfolio metrics in Kafka to be more efficient and real time with metrics update

Issue linked to PR is here: #284

Approach taken in PR is what is already mentioned in the issue

Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
@VithikaS VithikaS marked this pull request as draft March 1, 2023 09:15
@VithikaS VithikaS added the enhancement New feature or request label Mar 1, 2023
pom.xml Outdated Show resolved Hide resolved
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
@sonatype-lift
Copy link
Contributor

sonatype-lift bot commented Mar 1, 2023

🛠 Lift Auto-fix

Some of the Lift findings in this PR can be automatically fixed. You can download and apply these changes in your local project directory of your branch to review the suggestions before committing.1

# Download the patch
curl https://lift.sonatype.com/api/patch/github.com/DependencyTrack/hyades/351.diff -o lift-autofixes.diff

# Apply the patch with git
git apply lift-autofixes.diff

# Review the changes
git diff

Want it all in a single command? Open a terminal in your project's directory and copy and paste the following command:

curl https://lift.sonatype.com/api/patch/github.com/DependencyTrack/hyades/351.diff | git apply

Once you're satisfied, commit and push your changes in your project.

Footnotes

  1. You can preview the patch by opening the patch URL in the browser.

Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
@VithikaS VithikaS marked this pull request as ready for review March 2, 2023 10:42
@VithikaS VithikaS marked this pull request as draft March 2, 2023 10:50
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
@VithikaS VithikaS marked this pull request as ready for review March 6, 2023 13:30
Signed-off-by: vithikashukla <vithika.shukla14@gmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 14 Code Smells

89.6% 89.6% Coverage
0.0% 0.0% Duplication

@sahibamittal
Copy link
Collaborator

Upon testing, bug with the project count needs to be addressed (in separate PR probably).
#359

@sahibamittal
Copy link
Collaborator

sahibamittal commented Mar 7, 2023

LGTM, also tested end-to-end.

@VithikaS VithikaS merged commit 6e05fab into main Mar 7, 2023
@sahibamittal sahibamittal deleted the metrics-trial branch March 7, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants