Update supported PURL types for Snyk and bump default API version #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
sahibamittal
approved these changes
May 15, 2023
nscuro
added a commit
that referenced
this pull request
May 22, 2023
There are discrepancies between what SBOM generators report as PURL namespace and `distro` qualifier, and what Snyk expects. For example, trivy uses `redhat` for both, whereas Snyk expects `rhel`. The latter is also used by Syft. Problem is that batch requests to Snyk will fail entirely when at least one PURL in the batch does not comply with Snyk's preferred identifiers. There is no indication in the response as to which PURL caused the failure, so we can't filter them out and re-try the batch. Disabling Linux package types for now to not impact analysis of other package types. Reverts some changed made in #552 Signed-off-by: nscuro <nscuro@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.