Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Add API server and frontend #570

Merged
merged 1 commit into from
May 25, 2023
Merged

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented May 22, 2023

Both are disabled per default for the time being. The API server is enabled for local Minikube deployments. To test with it, port forwarding may be used.

I am not sure how to best setup the ingress for them in a way that does not require fiddling with /etc/hosts in local Minikube deployments.

Ideally, deploying to Minikube would be plug and play.

@nscuro nscuro added enhancement New feature or request deployment labels May 22, 2023
Both are disabled per default for the time being. The API server is enabled for local Minikube deployments. To test with it, port forwarding may be used.

 I am not sure how to best setup the ingress for them in a way that does not require fiddling with `/etc/hosts` in local Minikube deployments.

Ideally, deploying to Minikube would be plug and play.

Signed-off-by: nscuro <nscuro@protonmail.com>
@sonarcloud
Copy link

sonarcloud bot commented May 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Collaborator

@sahibamittal sahibamittal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@VinodAnandan VinodAnandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VinodAnandan VinodAnandan merged commit 695980a into main May 25, 2023
13 checks passed
@nscuro nscuro deleted the helm-apiserver-frontend branch July 18, 2023 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployment enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants