Refactor NVD and OSV parsing logic to fix incorrect version range parsing #756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nscuro
changed the title
nscuro
force-pushed
the
issue-733
branch
4 times, most recently
from
f426199
to
c470b85
Compare
2 tasks
Partly addresses #750 Signed-off-by: nscuro <nscuro@protonmail.com>
Partly addresses #750 Signed-off-by: nscuro <nscuro@protonmail.com>
Partly addresses #750 Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Taking inspiration from how the Open Vulnerability Project is doing it (https://github.com/jeremylong/Open-Vulnerability-Project/blob/main/open-vulnerability-store/src/main/java/io/github/jeremylong/openvulnerability/VulnerabilityTransformer.java#L202-L316), and how vanilla Dependency-Track does it (https://github.com/DependencyTrack/dependency-track/blob/master/src/main/java/org/dependencytrack/parser/nvd/NvdParser.java#L238-L269). Also fixed population of affected versions in the BOV. Fixes #733 Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
Partially addresses #760 Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
…pected Signed-off-by: nscuro <nscuro@protonmail.com>
Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro
changed the title
|
Kudos, SonarCloud Quality Gate passed! |
VithikaS
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AFFECTEDVERSIONATTRIBUTIONwhen uploading a BOM #731versranges and handle more edge cases (partially addresses OSV mirror produces invalid / ambiguous affected version ranges #760)WARN) logging when something odd or wrong is encountered during parsingFixes #733
Fixes #731