-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix breaking change in NEW_VULNERABILITY
notification JSON format
#775
Conversation
Companion change to DependencyTrack/hyades-apiserver#290 Note: Because the original field numbers and types remain untouched, this is not a breaking change schema-wise. The name of the fields has changed, but this is only relevant to the JSON output, which is exactly what we want to fix here. Signed-off-by: nscuro <nscuro@protonmail.com>
Both findings are expected, given my explanation in the description of this PR. |
Signed-off-by: nscuro <nscuro@protonmail.com>
I found more occurrences of where the JSON field name generated by Protobuf deviates from what was originally used in vanilla Dependency-Track. Thus,
Again, this is expected. |
…` notifications Signed-off-by: nscuro <nscuro@protonmail.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Companion change to DependencyTrack/hyades-apiserver#290
Note: Because the original field numbers and types remain untouched, this is not a breaking change schema-wise. The name of the fields has changed, but this is only relevant to the JSON output, which is exactly what we want to fix here.