Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Protobuf version with API server #897

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

nscuro
Copy link
Member

@nscuro nscuro commented Nov 6, 2023

Instead of relying on Quarkus bringing it in transitively, specify the Protobuf version explicitly, and also use that for protoc.

This is analog to how it's done in the API server.

Instead of relying on Quarkus bringing it in transitively, specify the Protobuf version explicitly, and also use that for `protoc`.

This is analog to how it's done in the API server.

Signed-off-by: nscuro <nscuro@protonmail.com>
@nscuro nscuro added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Nov 6, 2023
Copy link

sonarcloud bot commented Nov 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Collaborator

@VinodAnandan VinodAnandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nscuro nscuro merged commit b49ae16 into main Nov 6, 2023
12 checks passed
@nscuro nscuro deleted the align-protobuf-version branch November 6, 2023 14:26
@nscuro nscuro added this to the 0.3.0 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants