Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return QR code for new bot addition #9

Open
sherlockparadox opened this issue Apr 3, 2024 · 4 comments
Open

Return QR code for new bot addition #9

sherlockparadox opened this issue Apr 3, 2024 · 4 comments

Comments

@sherlockparadox
Copy link

Hi there!
Kudos on having a great plugin to allow direct bot push into the queue using API.

As far as I can see, there currently is a support to directly send steam auth guard code using bot index.
Just wanted to check if there will even be a functionality to login via QR code using the same bot index or get this QR code as response to adding the bot via existing addBot controller?

Thanks & Cheers!

@3urobeat
Copy link
Contributor

Hey, sorry for the very late response; both @DerDeathraven and I are currently busy with other projects.

If I recall correctly the bot currently does not send qrcode requests to plugins, only text & number based 2FA codes.
I'll have to see if and how that could be implemented (and documented).

We'll leave this issue open until then and I will update it when I've got something to share ^^

@sherlockparadox
Copy link
Author

Hi @3urobeat ! Thank you for your response!

I'm trying to study your code & figure out how to get this done by myself and probably raise a PR here as well. I'm not proficient in js.

Also, is there any way you can spill beans or give a sneak peek on this new project you guys are working on? 😋
Since you guys are pretty much always working on something crazy & fun!

Looking forward to checking out your new projects!
Cheers!

@3urobeat
Copy link
Contributor

Hey,
if you can figure out how to implement it yourself - sure! I always appreciate any PRs.

I did a quick look at my code, the bot sends normal 2fa codes to all plugins here and handles QR-Codes here.
I'm not exactly sure what the best implementation for QR-Codes would be, as we kinda have to indicate to plugins if the incoming request is a normal 2fa code or a QR-Code (maybe with a type param? or an additional function? idk).

Well regarding the other projects, I'm currently working on git-anon and DerDeathraven at some project for a customer, but I don't know exactly what.

3urobeat added a commit to 3urobeat/steam-comment-service-bot that referenced this issue May 1, 2024
@3urobeat
Copy link
Contributor

3urobeat commented May 1, 2024

The bot now has a steamGuardQrCode event, which can be handled from plugins using the steamGuardQrCode() function.
This plugin now needs to implement the function to make it accessible for applications that implement the API (unless this is already happening automatically?).

I'll post another comment when Version 2.15.2 of the bot is out, which will include the new event.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants