-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.6.1 #14
Merged
Merged
1.6.1 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adds an way to module settings easier. it requires some improvements and an checked state
This was
linked to
issues
Jul 10, 2023
var term = "/cordova.js"; | ||
for (var n = scripts.length - 1; n > -1; n--) { | ||
var src = scripts[n].src.replace(/\?.*$/, ""); // Strip any query param (CB-6007). | ||
if (src.indexOf(term) === src.length - term.length) { |
Check failure
Code scanning / CodeQL
Incorrect suffix check High
This suffix check is missing a length comparison to correctly handle indexOf returning -1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current changes
module.prop
file)Note
With the 1.6.1 update we're removing the option to download modules from the card. You'll have to open the module's readme to download the module.
Why?
There is a reason why module developers providing a readme for their module, you should read it and then download it.
Highlights
New Description API editor
Allows you preview description before you release it to MMRL!