Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Background moved 4px to the right in 16:10 and 21:9 #60

Closed
wojpawlik opened this issue Oct 3, 2020 · 6 comments
Closed

Background moved 4px to the right in 16:10 and 21:9 #60

wojpawlik opened this issue Oct 3, 2020 · 6 comments

Comments

@wojpawlik
Copy link

Correct:

16:9

Super Mario World (USA)-16_9

2:1

Super Mario World (USA)-2_1

Incorrect:

21:9

Super Mario World (USA)-21_9

16:10

Super Mario World (USA)-16_10

@DerKoun
Copy link
Owner

DerKoun commented Oct 5, 2020

The offset seems to be the remainder of dividing the widescreen area width by 8. Didn't find the cause at a quick glance at the code, but I'll look into it in detail.
Can I assume that the scale factor make no difference?

@wojpawlik
Copy link
Author

Yes, scale factor (Settings > Size) makes no difference.

@DerKoun
Copy link
Owner

DerKoun commented Feb 20, 2021

Fixed in new beta 10.4
The widescreen area size is now always rounded to a multiple of 8.
@wojpawlik Can you please confirm the issue is solved completely?

@DerKoun DerKoun closed this as completed Feb 20, 2021
@wojpawlik
Copy link
Author

Confirming fix:
obraz
obraz

@wojpawlik
Copy link
Author

Curious (not complaining), why did the scanline shader turn on after 10.3 -> 10.4 upgrade, even tho it's not listed?

obraz

@DerKoun
Copy link
Owner

DerKoun commented Feb 21, 2021

That's actually the widescreen marker being rendered incorrectly for scales of 2 or higher. I have pushed another hotfix for that. Thanks for reporting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants