Re-issuing v2.4.0 #277
Merged
Re-issuing v2.4.0 #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature selection. Also: using <> instead of double quote if the header is not on relative path.
|
@etremel I've reg-tested this version with the latest cascade master branch. It works as I expected. You can go ahead with another pass of the change. I think it's ready to merge to the master for reissuing v2.4.0. |
|
Thanks, this looks good. I'll have to merge this pull request first and then re-apply my changes to make USE_VERBS_API compile, since I can't add commits to your repository, but that shouldn't be too hard. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After a discussion with Edward, we decided to re-issue v2.4.0 with the following changes:
includedirectives (from "" to <>), andconfig.h.inso that HMEM feature is controlled and v2.4.0 works for 'tcp' and 'socket' libfabric providers.TODO: include Edward's changes making USE_VERBS_API compilable (not tested and not recommended as we've developed around libfabric for years.)