remove any usage of innerHTML (ampproject#6666)

DerekNonGeneric · Sep 13, 2023 · 3153206 · 3153206
1 parent 21274da
commit 3153206
Showing 1 changed file with 14 additions and 4 deletions.
diff --git a/examples/static/samples/files/amp_url_converter.js b/examples/static/samples/files/amp_url_converter.js
@@ -40,16 +40,26 @@ class AmpUrlConverter {
       .catch(this.showError.bind(this));
   }
 
+  clearResultView() {
+    while (this.resultView.firstChild) {
+      this.resultView.removeChild(this.resultView.firstChild);
+    }
+  }
+
   showError() {
+    this.clearResultView();
     this.resultView.className = 'error';
-    this.resultView.innerHTML = 'invalid URL';
+    this.resultView.textContent = 'invalid URL';
   }
 
   showResult(cacheUrl) {
-    const result =
-      '<a href="' + cacheUrl + '" target="_blank">' + cacheUrl + '</a>';
+    this.clearResultView();
+    const result = window.document.createElement('a');
+    result.setAttribute('href', cacheUrl);
+    result.setAttribute('target', '_blank');
+    result.textContent = cacheUrl;
     this.resultView.className = '';
-    this.resultView.innerHTML = result;
+    this.resultView.appendChild(result);
   }
 
   onChange() {