Skip to content

Commit

Permalink
Camera: Removing cachedump call to miminimize delay during close.
Browse files Browse the repository at this point in the history
- The cacheDump() call was added for better debugging by always
  dumping the state of the last camera session. Since LT/VT chipsets
  it is adding significant delay during camera close. Hence we are
  removing cachedump call during disconnect.
  https://partnerissuetracker.corp.google.com/issues/237992867

CRs-Fixed: 3228616
Change-Id: Ibba2a51f08c592bf15b046642101e11d890ed248
Signed-off-by: Pranav Vashi <neobuddy89@gmail.com>
  • Loading branch information
Venugopal Nadipalli authored and NurKeinNeid committed Apr 3, 2024
1 parent b836b7f commit 587d271
Showing 1 changed file with 0 additions and 8 deletions.
8 changes: 0 additions & 8 deletions services/camera/libcameraservice/common/Camera2ClientBase.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -272,14 +272,6 @@ binder::Status Camera2ClientBase<TClientBase>::disconnectImpl() {

ALOGD("Camera %s: Shutting down", TClientBase::mCameraIdStr.c_str());

// Before detaching the device, cache the info from current open session.
// The disconnected check avoids duplication of info and also prevents
// deadlock while acquiring service lock in cacheDump.
if (!TClientBase::mDisconnected) {
ALOGD("Camera %s: start to cacheDump", TClientBase::mCameraIdStr.c_str());
Camera2ClientBase::getCameraService()->cacheDump();
}

detachDevice();

CameraService::BasicClient::disconnect();
Expand Down

0 comments on commit 587d271

Please sign in to comment.