Regional officer column #16
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added functionality to save details of Regional Officers in the sheet.
NS usually doesn't allow blank officer titles. But someone found a way to do this (by entering a single space as title, which becomes blank). So the program crashed. This should be fixed now.
…pseh-master Merge ??
Open
Open
|
Thanks for submitting this! Right now, I am going to close this pull request unmerged. We are in the midst of refactoring the sheet generation code, so it will be better to wait until the dust settles. When 2.1 is released, please submit your pull request against that instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a column with the regional officers (nations and their titles) of each region.
Note: to do this I had to shift the Spyglass version/time/etc info one column to the right.
(You can ignore the many commits, most of them are from the old 1.4.4 patch since I don't really know how "git" works and how to create a new setup for the 2.0 version. The "Files changed" tab shows what the actual changes are. If adding this pull request directly is undesirable because of all the irrelevant commits, please just add the changes manually.)