Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CLI flags for custom update lengths #25

Merged
merged 2 commits into from Nov 2, 2022
Merged

Conversation

esfalsa
Copy link
Contributor

@esfalsa esfalsa commented Sep 10, 2022

This PR adds support for the -maj and -min CLI flags to specify custom lengths. This exposes the same functionality as is currently available in interactive mode.

@esfalsa esfalsa changed the title Add CLI flags for custom update lenghts Add CLI flags for custom update lengths Sep 10, 2022
@AavHRF AavHRF self-assigned this Oct 25, 2022
@AavHRF AavHRF self-requested a review October 25, 2022 20:29
@AavHRF
Copy link
Collaborator

AavHRF commented Oct 25, 2022

I'm not quite confident that we want to add those flags back. If I recall correctly, we specifically removed the -maj flag in the 2.0 release due to a change in how we handled time calculations. -min makes sense though.

@esfalsa
Copy link
Contributor Author

esfalsa commented Oct 25, 2022

Hmm, do you remember what exactly the issue was? The -maj flag as I've implemented it should function the same as the existing functionality for manually specifying an update length, so I figured it would work the same way with respect to time calculations, but I can check the code again.

@AavHRF
Copy link
Collaborator

AavHRF commented Oct 26, 2022

Hmm, do you remember what exactly the issue was? The -maj flag as I've implemented it should function the same as the existing functionality for manually specifying an update length, so I figured it would work the same way with respect to time calculations, but I can check the code again.

I don't remember, unfortunately. Upon testing, however, there seems to be no issue so perhaps I'm confusing this with a change I made in the beta branch. As long as nobody else on the development team is opposed to this change I will merge it into master.

@AavHRF AavHRF linked an issue Oct 26, 2022 that may be closed by this pull request
@khronion khronion added this to the 2.0.3 milestone Oct 30, 2022
@khronion khronion merged commit 5c24e4a into Derpseh:master Nov 2, 2022
@khronion
Copy link
Collaborator

khronion commented Nov 2, 2022

Changes merged. Thank you @esfalsa!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot override update speeds with runtime flags
3 participants