Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unittests for misc #251

Merged
merged 1 commit into from
May 1, 2024
Merged

Unittests for misc #251

merged 1 commit into from
May 1, 2024

Conversation

winterheart
Copy link
Collaborator

Pull Request Type

  • GitHub Workflow changes
  • Documentation or Wiki changes
  • Build and Dependency changes
  • Runtime changes
    • Render changes
    • Audio changes
    • Input changes
    • Network changes
    • Other changes

Description

Related Issues

Unittests that used for testing refactored CleanupStr() in #207.

Screenshots (if applicable)

Checklist

  • I have tested my changes locally and verified that they work as intended.
  • I have documented any new or modified functionality.
  • I have reviewed the changes to ensure they do not introduce any unnecessary complexity or duplicate code.
  • I understand that by submitting this pull request, I am agreeing to license my contributions under the project's license.

Additional Comments

@winterheart
Unittests for misc
d82d3a2 
Unittests that used for testing refactored CleanupStr() in DescentDevelopers#207.
@Lgt2x
Copy link
Collaborator

Lgt2x commented May 1, 2024

nice!

@Lgt2x Lgt2x merged commit d132a1c into DescentDevelopers:main May 1, 2024
10 checks passed
Jayman2000 added a commit to Jayman2000/Descent3-pr that referenced this pull request May 1, 2024
@Jayman2000
[WIP] Fix variable name in Linux build instructions
b9738b1 
0b41a1b (CMake: expose BUILD_TESTNG option, rename LOGGER to
ENABLE_LOGGER, 2024-04-29) had originally introduced this change. It
looks like d132a1c (Merge pull request DescentDevelopers#251 from
winterheart/pstring-unittests, 2024-05-01) unintentionally removed this
change.

TODO: Test
Jayman2000 added a commit to Jayman2000/Descent3-pr that referenced this pull request May 1, 2024
@Jayman2000
Fix variable name in Linux build instructions
0833788 
0b41a1b (CMake: expose BUILD_TESTNG option, rename LOGGER to
ENABLE_LOGGER, 2024-04-29) had originally introduced this change. It
looks like d132a1c (Merge pull request DescentDevelopers#251 from
winterheart/pstring-unittests, 2024-05-01) unintentionally removed this
change.
@Jayman2000 Jayman2000 mentioned this pull request May 1, 2024
Merged
13 tasks
Jayman2000 added a commit to Jayman2000/Descent3-pr that referenced this pull request May 2, 2024
@Jayman2000
Fix variable name in Linux build instructions
5780f94 
0b41a1b (CMake: expose BUILD_TESTNG option, rename LOGGER to
ENABLE_LOGGER, 2024-04-29) had originally introduced this change. It
looks like d132a1c (Merge pull request DescentDevelopers#251 from
winterheart/pstring-unittests, 2024-05-01) unintentionally removed this
change.
JeodC pushed a commit that referenced this pull request May 2, 2024
@Jayman2000 @JeodC
Fix variable name in Linux build instructions
67ecea0 
0b41a1b (CMake: expose BUILD_TESTNG option, rename LOGGER to
ENABLE_LOGGER, 2024-04-29) had originally introduced this change. It
looks like d132a1c (Merge pull request #251 from
winterheart/pstring-unittests, 2024-05-01) unintentionally removed this
change.
@winterheart winterheart deleted the pstring-unittests branch May 27, 2024 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@winterheart @Lgt2x