Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unconditionally setting no optimization and debug symbols #30

Closed
wants to merge 1 commit into from

Conversation

danra
Copy link
Contributor

@danra danra commented Apr 17, 2024

in macOS/Linux release builds

@danra danra changed the title Avoid unconditionally setting no optimization and debug symbols in ma… Avoid unconditionally setting no optimization and debug symbols Apr 17, 2024
@Arcnor
Copy link
Collaborator

Arcnor commented Apr 17, 2024

Hi, thanks for your PR!

LIST(APPEND CMAKE_CXX_FLAGS... cannot really work, as CMAKE_CXX_FLAGS is not a list (it's a space separated string, you can see at https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_FLAGS.html)

You can do instead STRING(APPEND... which will use spaces instead. Other than that, I think it looks good.

@Arcnor Arcnor self-assigned this Apr 17, 2024
@danra
Copy link
Contributor Author

danra commented Apr 17, 2024

Good catch, will fix.
Also #46

@Arcnor
Copy link
Collaborator

Arcnor commented Apr 18, 2024

Superseded by #54

@Arcnor Arcnor closed this Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants