-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introducing installation steps #318
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing dependencies like fmt.dll and should also pack dmfc if it exists (separate PR open to build that).
Optional suggestion: Use legacy/D3Launch/res/D3Launch.ico
as Descent3.ico
and assign it directly to the binary.
3f83f40
to
6a3154e
Compare
8b67553
to
c680271
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, local install and artifacts look correct. Merging when rebased
Added installation steps for all built targets. Added FORCE_PORTABLE_INSTALL cmake option that controls portable installation (only supported for now).
c680271
to
08b906f
Compare
Rebased. |
Pull Request Type
Description
Added installation steps for all built targets. Added FORCE_PORTABLE_INSTALL cmake option that controls portable installation (only supported for now).
Related Issues
Screenshots (if applicable)
Checklist
Additional Comments