Re-apply cfile-update with fix regression #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lgt2x
reviewed
Apr 19, 2024
|
Here additional regressions I've found in 32bit mode... |
winterheart
force-pushed
the
cfile-update-v2
branch
2 times, most recently
from
d27f8c8
to
143db92
Compare
|
PR ready to merge, though additional testing on Windows would be useful. |
winterheart
force-pushed
the
cfile-update-v2
branch
3 times, most recently
from
fdaf346
to
d6c0901
Compare
Arcnor
requested changes
Apr 21, 2024
Closed
winterheart
force-pushed
the
cfile-update-v2
branch
2 times, most recently
from
f16be9d
to
7c59df0
Compare
Arcnor
requested changes
Apr 23, 2024
winterheart
force-pushed
the
cfile-update-v2
branch
from
7c59df0
to
99193f7
Compare
This reverts commit 066b436.
cfgetc returns int on success read, but if cast it to int8_t too early, 255 will become -1, or EOF.
Whoah, big surprise float_t and double_t may have different length. Still waiting float32_t and float64_t types from C++23...
Other modules that depends on it, can reuse includes on linking. There some files formally not belonging any packages (lib directory), as workaround there temporary include_directories(cfile) on root of project. After migrating all modules this can be removed.
winterheart
force-pushed
the
cfile-update-v2
branch
from
99193f7
to
4826c37
Compare
Arcnor
approved these changes
Apr 23, 2024
JeodC
pushed a commit
that referenced
this pull request
Apr 28, 2024
Re-apply cfile-update with fix regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging #76 there was regression found in #88. This PR re-applies changes with additional fix.