fix: GetAvailableLanguages now returns the correct list of languages when additional OCR languages have been installed directly, without adding a system language. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when additional OCR languages have been installed directly, without adding a system language. The original implementation gets the list of `Languages` from the `Windows.System.UserProfile.GlobalizationPreferences` class, then checks if each language has OCR support, by calling `IsLanguageSupported` from the `Windows.Media.Ocr.OcrEngine` class. This returns an incomplete list of supported OCR languages since the user may directly install additional OCR languages without adding a system language. The new implementation fetches the list of `AvailableRecognizerLanguages` directly from the `Windows.Media.Ocr.OcrEngine` class, instead of fetching the list of languages from the `Windows.System.UserProfile.GlobalizationPreferences` class and then checking for OCR support.
|
Thanks for the contribution! The fix has been implemented, and also led me to discover a memory leak in both the old version and the new, where the HString was not being properly released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original implementation gets the list of
Languagesfrom theWindows.System.UserProfile.GlobalizationPreferencesclass, then checks if each language has OCR support, by callingIsLanguageSupportedfrom theWindows.Media.Ocr.OcrEngineclass. This returns an incomplete list of supported OCR languages since the user may directly install additional OCR languages without adding a system language. The new implementation fetches the list ofAvailableRecognizerLanguagesdirectly from theWindows.Media.Ocr.OcrEngineclass, instead of fetching the list of languages from theWindows.System.UserProfile.GlobalizationPreferencesclass and then checking for OCR support.How to install an OCR language pack
The following commands install the OCR pack for "ja-JP":