Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add chart functionality to show sensors values for the past hour #18

Merged
merged 14 commits into from Mar 31, 2022

Conversation

Elleo
Copy link
Contributor

@Elleo Elleo commented Mar 28, 2022

I don't know if this is of interest, but I thought I'd share it in case you'd like this functionality upstream as well.

This pull request:

  • Adds jQuery, moment and chart.js libraries
  • Updates existing code to use jQuery for less verbose access to DOM elements
  • Adds chart displays for each sensor. If you tap a sensor metric on the summary page the summary is hidden and a chart of that sensor's data for the past hour is displayed. Tapping again, anywhere on the screen, will return you to the summary page

A short video showing this functionality can be seen here: https://www.youtube.com/watch?v=AefVGVBTMG4

@9600
Copy link
Member

9600 commented Mar 29, 2022

Hi @Elleo, this looks great and many thanks for the PR, it's appreciated!

We'll review in due course with a view to merging.

@9600 9600 requested a review from callumsnowden March 29, 2022 13:05
@9600 9600 added the enhancement New feature or request label Mar 29, 2022
@Elleo
Copy link
Contributor Author

Elleo commented Mar 29, 2022

Great, thanks :)

@callumsnowden callumsnowden merged commit c90bde7 into DesignSparkRS:main Mar 31, 2022
@callumsnowden
Copy link
Contributor

I've had this on test this morning and found no issues with it, it looks great!

@Elleo Elleo deleted the charts branch March 31, 2022 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants