Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Header should not streatch to extreme sides #32

Open
jayeshchoudhary opened this issue Sep 30, 2021 · 3 comments
Open

[BUG] Header should not streatch to extreme sides #32

jayeshchoudhary opened this issue Sep 30, 2021 · 3 comments

Comments

@jayeshchoudhary
Copy link

jayeshchoudhary commented Sep 30, 2021

🙁 Actual behavior

Currently, app header is stretching to extreme sides. It should have some left and right padding to look good.
also, there is way too much margin on top of the header.

image

🙂 Expected behavior

There should be some spacing around app header (left and right) also decrease top margin a bit.

🔢 Steps to Reproduce the Problem

go to home page and verify

jayeshchoudhary pushed a commit to jayeshchoudhary/thedesignsystems that referenced this issue Sep 30, 2021
jayeshchoudhary added a commit to jayeshchoudhary/thedesignsystems that referenced this issue Sep 30, 2021
@yashsehgal
Copy link
Contributor

Well, it's due to different screen sizes. If you've made it work for all the possible screen widths then it's a great fix to be merged.

@jayeshchoudhary
Copy link
Author

@yashsehgal It is present even for desktop screen
I have created a PR for the same

@yashsehgal
Copy link
Contributor

Please do refer to these changes - #33 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants