Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sphere bounding box #1307

Merged
merged 5 commits into from
Feb 27, 2024
Merged

Fix sphere bounding box #1307

merged 5 commits into from
Feb 27, 2024

Conversation

WirajanDASILVA
Copy link
Collaborator

  • Please check if the PR fulfills these requirements
  • The commit messages follows our guidelines (explicit, in english)
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • CHANGELOG.md has been updated
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
  • Bug fix:
  • New features:
  • Documentation
  • Optimization
  • Other information:

@WirajanDASILVA WirajanDASILVA linked an issue Feb 26, 2024 that may be closed by this pull request
Bug: sphere face #1305
Open
1 task
GabrielJMS
GabrielJMS requested changes Feb 26, 2024
View reviewed changes
tests/faces/test_sphericalface3d.py Show resolved Hide resolved
volmdlr/faces.py Outdated Show resolved Hide resolved
@WirajanDASILVA WirajanDASILVA merged commit f26588e into dev Feb 27, 2024
2 checks passed
@WirajanDASILVA WirajanDASILVA deleted the fix_sphere branch February 27, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GabrielJMS GabrielJMS GabrielJMS approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: sphere face
2 participants
@WirajanDASILVA @GabrielJMS