Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add up enhanced perk stats correctly #10580

Merged
merged 1 commit into from
Jun 24, 2024
Merged

Add up enhanced perk stats correctly #10580

merged 1 commit into from
Jun 24, 2024

Conversation

bhollis
Copy link
Contributor

@bhollis bhollis commented Jun 19, 2024

Fixes #10479. A good example that's still in the defs is Enhanced Lasting Impact, which showed only a +3 blast radius before, and now shows +53:

Screenshot 2024-06-19 at 2 55 10 PM Screenshot 2024-06-19 at 2 54 58 PM

@StardustD2 once this goes in you might want to look at some of the descriptions, since you won't need to re-state these stat bonuses.

@StardustD2
Copy link

Investment stat bonuses are always an iffy topic for me. For example, the iron banner perks don't even have tooltips because those purely affect the investment stats and I have nothing else to note there.

But with enhancement changing those and all that stuff, I might want to add tooltips even for those so that people will see the enhancement benefit directly on the enhanced perk instead of needing to compare to the base versions manually. With DIM, this certainly adds a level of redundancy to the info which isn't ideal but I'm of the opinion that tooltips should give people the full context as opposed to needing external info like what DIM is doing here.

The non-DIM-related reason for this approach is that there are other apps that don't even show the investment stat changes either at all or not so directly. So those then rely on our end having all the relevant info about a perk.

@bhollis bhollis merged commit 467784a into master Jun 24, 2024
7 checks passed
@bhollis bhollis deleted the enhanced-stats branch June 24, 2024 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhanced Bipod stat penalties are displayed incorrectly
2 participants