Fix DIM hanging when trying to show record books #1145
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1014 made a change to how we display objective rows, and included code to display a bubble for each Trials win. It did this with an
ng-repeat
over the range of an objective's completionValue. Unfortunately, in the RoI record book are objectives with completion values that can be in the thousands. This causes us to allocate a thousands-long array and then evaluate the template thousands of times. There's anng-if
making sure each of these doesn't get put into the document, but it's too late - it only happens after each element in theng-repeat
. Wrapping the items in adiv
that has theng-if
case (actuallyng-switch
, which fits better here) means we evaluate trials-ness only once per objective.Fixes #1142.
/cc @kyleshay