Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add translations for stat quality #1202

Merged
merged 4 commits into from Nov 24, 2016
Merged

add translations for stat quality #1202

merged 4 commits into from Nov 24, 2016

Conversation

delphiactual
Copy link
Contributor

@simonefranza identified a missing translation on the move-popup

@@ -203,6 +203,9 @@
Discipline: "Discipline",
Intellect: "Intellect",
NoBonus: "No Bonus",
OfMaxRoll: "of max roll",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it should be a full sentence with a substitution rather than a fragment (something like {{range}} of max roll

@bhollis bhollis merged commit 08b356f into DestinyItemManager:dev Nov 24, 2016
@bhollis
Copy link
Contributor

bhollis commented Nov 24, 2016

Great!

@delphiactual delphiactual deleted the stats-quality branch December 11, 2016 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants