Fix #1335, which as far as I can tell is a Chrome bug? #1345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in question, which reloads stores and retries if you don't have space do do a move, hasn't changed since July or so, and it's been working fine. Now, all of a sudden, it's failing to capture
storein thethenhandler. Pausing at the debugger or usingconsole.logconfirms thatstoreis present outside the closure, andundefinedwithin. Capturing just the ID appears to fix it. While I'm generally hesitant to blame browser bugs, this sounds like a bad optimization in a recent V8, or maybe store is getting (improperly) garbage collected before the closure is run. I haven't found the right search terms to find any existing bug report.