bootspec: relax the extensions type #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, extensions would need to round-trip through
serde_json in order to be able to become a given extension type:
let extension: &HashMap<String, serde_json::Value> = bootspec.extensions.get("org.test").unwrap();
let extension: OrgTestExtension = serde_json::from_value(serde_json::to_value(extension).unwrap()).unwrap();
Now, however, you can directly deserialize the extension into a type:
let extension: &serde_json::Value = bootspec.extensions.get("org.test").unwrap();
let extension: OrgTestExtension = serde_json::from_value(extension.to_owned()).unwrap();
cole-h
force-pushed
the
relax-extensions-type
branch
from
81aa9e2
to
34c1590
Compare
Internal nulls are not specified (read: allowed).
cole-h
commented
May 5, 2023
| @@ -35,6 +35,14 @@ impl<'de> Visitor<'de> for BootSpecExtensionsVisitor { | |||
| map.insert(key, value); | |||
| } | |||
|
|
|||
| for (k, v) in map.iter() { | |||
| if v.is_null() { | |||
There was a problem hiding this comment.
Note that this doesn't preclude e.g. "org.test": { "enableSomeSetting": null } -- only "org.test": null
grahamc
approved these changes
May 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change, extensions would need to round-trip through serde_json in order to be able to become a given extension type:
Now, however, you can directly deserialize the extension into a type:
Description
Checklist
cargo buildcargo fmtcargo clippycargo test