Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop setting the default source branch to 'main' #36

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Mar 6, 2024

Description

This will cause new pulls from i.d.s to fetch the latest tag.

Checklist
  • Tested changes against a test repository
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • (If this PR is for a release) Updated README to point to the new tag (leave unchecked if not applicable)

@lucperkins lucperkins self-requested a review March 6, 2024 15:38
@colemickens
Copy link
Member

Presumably this falls through to return${urlPrefix}/latest/${binarySuffix};? Just making sure, that still looks unversioned.

@grahamc
Copy link
Member Author

grahamc commented Mar 6, 2024

Presumably this falls through to return${urlPrefix}/latest/${binarySuffix};? Just making sure, that still looks unversioned.

That's right, it'll continue pulling an unversioned "Latest". Ideally we could pull these artifacts from flakehub with nice semver goodness.

@grahamc grahamc merged commit 54acdd1 into main Mar 6, 2024
2 checks passed
@grahamc grahamc deleted the grahamc-patch-1 branch March 6, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants