Behave well when MNCA isn't trusted #52
Conversation
| actionsCore.warning(TEXT_TRUST_UNTRUSTED); | ||
| return; | ||
| } else if (cacheAction.idslib.nixStoreTrust === "unknown") { | ||
| actionsCore.info(TEXT_TRUST_UNKNOWN); |
There was a problem hiding this comment.
I don't think so: it may be unknown if they're using a remote ssh store, for example. I don't want to emit useless warnings for scenarios we're not certain are worth a warning.
| return; | ||
| } | ||
|
|
||
| if (cacheAction.idslib.nixStoreTrust === "untrusted") { | ||
| actionsCore.warning(TEXT_TRUST_UNTRUSTED); |
There was a problem hiding this comment.
Do we really want to exit with a warning instead of just erroring? If the runner user isn't trusted, then there's no point in having this action, and if that were me, I'd want to be notified that this is what happened (i.e. I personally would expect an error).
There was a problem hiding this comment.
Philosophically I look at it like where we only warn and go into noop mode if Nix isn't installed. I'd rather not force the user to delete the action altogether if the trust situation is just temporary.
|
Well, the untrusted test failed, so probably want to fix that first (maybe make it required?). |
Description
Checklist