Use indexmap #25
Merged
Use indexmap #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
reviewed
Oct 2, 2023
|
|
||
| let map = res.unwrap(); | ||
|
|
||
| // Ensure it's not just luck that it's the same order... |
There was a problem hiding this comment.
I wonder if there's a better way to test for this... Right now, just transplanting this test into the current HashMap implementation, I get this to pass like 4/10 attempts...
There was a problem hiding this comment.
Short of asserting the type is an indexmap, I'm not sure how we'd do that. There isn't like a OrderedIterator marker or anything.
cole-h
approved these changes
Oct 2, 2023
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The processed order and the output order should be as similar as possible, also the output ordering should be deterministic.
Checklist
cargo fmt