Support GitHub Enterprise Server using ARC #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is special in that it doesn't have systemd, and it'd be great to support Namespace.so. It is also a good test case for a variety of self-hosted GHA runner use cases.
…stemd This change introduces a Docker container shim which spawns the Nix daemon after bind mounting all the relevant paths into the container. The image is actually completely empty, other than metadata about what to run. This is a cheap and cheerful way to get decent process supervision in environments that don't bring systemd, but do have docker ... which is most everywhere in the GHA ecosystem.
grahamc
force-pushed
the
graham/fh-82-nix-installer-action-explore-how-to-support-arc
branch
from
8f4a865
to
6f44f1f
Compare
cole-h
reviewed
Dec 4, 2023
cole-h
reviewed
Dec 4, 2023
colemickens
approved these changes
Dec 4, 2023
cole-h
approved these changes
Dec 4, 2023
grahamc
force-pushed
the
graham/fh-82-nix-installer-action-explore-how-to-support-arc
branch
from
a4821ae
to
1aa8f3f
Compare
grahamc
deleted the
graham/fh-82-nix-installer-action-explore-how-to-support-arc
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the action's support for environments unlike GitHub's own hosted runners. In particular, runners that don't expose systemd as PID1. This is common for GitHub Enterprise Server users, which often use something called ARC: https://github.com/actions/actions-runner-controller.
As a happy coincidence, this also closely matches other third party runners, like Namespace.
The implementation here is to fall back to borrowing Docker as a process supervisor if all three of the following are true:
This PR includes a pre-built Docker image for arm64 and amd64 in the repository, since the images are completely empty other than some configuration. This patch also updates the
trusted-usersconfiguration option, to use the OS to get the username instead of using an environment variable, which is not always available.This patch has been tested in GHES and on Namespace, and confirmed to work.
Checklist