Add more failure context / Improve error structure #296

Hoverbear · 2023-03-02T19:46:14Z

Description

Offer users might nicer, more contextual errors:

Checklist

Formatted with cargo fmt
Built with nix build
Ran flake checks with nix flake check
Added or updated relevant tests (leave unchecked if not applicable)
Added or updated relevant documentation (leave unchecked if not applicable)
Linked to related issues (leave unchecked if not applicable)

Validating with `install.determinate.systems`

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

Hoverbear · 2023-03-02T19:46:57Z

I need to fix some issues with the linenumber being reported wrong...

src/action/base/add_user_to_group.rs

src/diagnostics.rs

src/action/macos/create_fstab_entry.rs

src/action/common/place_nix_configuration.rs

src/action/common/configure_nix.rs

…-diagnostics

Hoverbear added 6 commits February 27, 2023 14:57

wip: add more context to errors

51e7fe2

Add a bunch fo context

7bc6380

Repair source handling

1a45b47

Add remaining contexts

c996123

Add some context, but some of it is not right...

f5e0ba0

Tidy up contexts properly

8299524

Hoverbear self-assigned this Mar 2, 2023

Hoverbear changed the title ~~Hoverbear/ds 691 add more failure context to diagnostics~~ Add more failure context / Improve error structure Mar 3, 2023

Hoverbear added 3 commits March 3, 2023 09:47

Get command errors working how I want

b77fa62

Remove some debug statements

56ac1bb

Repair mac build

b260c81

Hoverbear marked this pull request as ready for review March 3, 2023 17:57

Hoverbear requested a review from cole-h March 3, 2023 17:57