-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup multiple --extra-conf usages #456
Conversation
We found some additional fix to do! |
@cole-h and I noticed that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Neat use of the entry API.
} | ||
}, | ||
Entry::Vacant(slot) => { | ||
let _ = slot.insert(experimental_features.join(" ").to_string()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this let _ = ...
necessary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess { slot.insert(); }
is valid but for some reason I felt like being rather explicit that we don't want that return type.
Hey there, I'm also running into #427 and looking forward to using this fix :)
Any chance of adding this label so we might use it in the meantime? PS: Thanks for all your work on nix-installer! Loving it so far ❤️ |
Gosh sorry, I didn't see this! The changes should be out on 0.9.0: curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/tag/v0.9.0 | sh -s -- install |
Description
Fixes #427
Checklist
cargo fmt
nix build
nix flake check
Validating with
install.determinate.systems
If a maintainer has added the
upload to s3
label to this PR, it will become available for installation viainstall.determinate.systems
: