Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clippy nits while hacking around #737

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Clippy nits while hacking around #737

merged 4 commits into from
Nov 22, 2023

Conversation

grahamc
Copy link
Member

@grahamc grahamc commented Nov 22, 2023

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

@grahamc grahamc marked this pull request as ready for review November 22, 2023 17:27
@cole-h
Copy link
Member

cole-h commented Nov 22, 2023

Should we add clippy to CI so that we don't regress here?

@Hoverbear
Copy link
Contributor

@cole-h it's already run in lints.

@Hoverbear Hoverbear added this to the 0.15.2 milestone Nov 22, 2023
@grahamc
Copy link
Member Author

grahamc commented Nov 22, 2023

How did we regress then? 🤔

@grahamc grahamc merged commit 41a96f4 into main Nov 22, 2023
13 checks passed
@grahamc grahamc deleted the clippy-nits branch November 22, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants