Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup uninstall tag links #812

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fixup uninstall tag links #812

merged 1 commit into from
Jan 10, 2024

Conversation

cole-h
Copy link
Member

@cole-h cole-h commented Jan 10, 2024

We tag with a leading v, but the messages did not have this.

Description
Checklist
  • Formatted with cargo fmt
  • Built with nix build
  • Ran flake checks with nix flake check
  • Added or updated relevant tests (leave unchecked if not applicable)
  • Added or updated relevant documentation (leave unchecked if not applicable)
  • Linked to related issues (leave unchecked if not applicable)
Validating with install.determinate.systems

If a maintainer has added the upload to s3 label to this PR, it will become available for installation via install.determinate.systems:

curl --proto '=https' --tlsv1.2 -sSf -L https://install.determinate.systems/nix/pr/$PR_NUMBER | sh -s -- install

We tag with a leading `v`, but the messages did not have this.
@cole-h cole-h requested a review from Hoverbear January 10, 2024 20:37
@cole-h cole-h self-assigned this Jan 10, 2024
@Hoverbear Hoverbear enabled auto-merge (squash) January 10, 2024 20:37
@Hoverbear Hoverbear added this to the 0.16.1 milestone Jan 10, 2024
@cole-h
Copy link
Member Author

cole-h commented Jan 10, 2024

Note that I didn't change a similar pattern in the README because it is actually correct (the ${VERSION} includes the leading v).

@Hoverbear Hoverbear merged commit 62afef6 into main Jan 10, 2024
13 checks passed
@Hoverbear Hoverbear deleted the fixup-tag-links branch January 10, 2024 20:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants