Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure out what to do with premailer dependency #54

Closed
mbohal opened this issue Oct 13, 2019 · 1 comment
Closed

Figure out what to do with premailer dependency #54

mbohal opened this issue Oct 13, 2019 · 1 comment
Labels
enhancement New feature or request refactoring

Comments

@mbohal
Copy link
Contributor

mbohal commented Oct 13, 2019

Currently the project depends on the grunt-premailer npm package which depends on ruby and the premailer gem.

Currently ruby is not installed in the docker container and the grunt mail command therefore fails. There are two options how to resolve this:

  1. Get rid of the grunt-premailer dependency and build mail templates by some other means
  2. Install ruby and the required premailer gem into the docker containers

I think solution 1. is preferable as it would simplify the stack and make development and contributions easier.

@mbohal mbohal added enhancement New feature or request refactoring labels Oct 13, 2019
@mbohal
Copy link
Contributor Author

mbohal commented Oct 18, 2019

After discussion with @adamkudrna the premailer/ink stack for generating email template has been removed. It is not maintained anymore and it was not possible to keep it around after removing bower.

It has no effect on current installation. The only problem will be when changes will have to be made to the existing email template. When that happens another solution will have to be found.

@mbohal mbohal closed this as completed Oct 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request refactoring
Projects
None yet
Development

No branches or pull requests

1 participant