Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update for Symphony 4.x #75

Open
wants to merge 19 commits into
base: master
Choose a base branch
from
Open

Update for Symphony 4.x #75

wants to merge 19 commits into from

Conversation

alexnantel88
Copy link

Update release version.
Output language code instead of full name.

@alexnantel88
Copy link
Author

wait for @nitriques to merge it

@nitriques nitriques mentioned this pull request Oct 23, 2017
Closed
nitriques pushed a commit that referenced this pull request Oct 24, 2017
@nitriques
Fix compatibility warnings for PHP7
02ee03b 
Picked from 2d0869f
Re #75
Fixes #79
nitriques pushed a commit that referenced this pull request Oct 24, 2017
@nitriques
Remove deprecated param from buildSortingSQL
6758d0e 
Picked from 132d912
Re #75
nitriques pushed a commit that referenced this pull request Oct 24, 2017
@nitriques
Fix error detection bug in publish panel
dc7665e 
Picked from c6b6c57
Re #75
nitriques pushed a commit that referenced this pull request Oct 24, 2017
@nitriques
SQL and PHP cases
fc6fb38 
PHP true,false,null in lowercase
SQL keywords uppercase

Picked fro 65438a2
Re #75
@nitriques
Copy link
Member

I've picked 2d0869f, 132d912, c6b6c57 and 65438a2 (the last 4 commits).

Can you rebase and keep only the first 3 commits please ? Thanks !

@nitriques nitriques assigned nitriques and alexnantel88 and unassigned nitriques Oct 24, 2017
@beaubbe
Copy link
Contributor

beaubbe commented Oct 16, 2018

@alexnantel88 There is a problem whith the isHandleLocked function which breaks the unique handle creation. WHen entry id is not null, a new where statement is added for the entry id. The evaluation should not be "$q->where(['f.entry_id' => $entry_id]);"m it should be "$q->where(['f.entry_id' => ['!=' => $entry_id]]);".
This is how it was for symphony 2.7. Without the "!=", handles wont be unique.

Alexandra Nantel added 15 commits October 19, 2018 15:12
Update for Symphony 4.x
40a81d3 
Update release version.
Output language code instead of full name.
Place checkbox before string in label
70b0e23
Update php-min/php-max info
02af0b7
Begin code refactoring with new Database methods
40a7ac2
Use array_merge to create fields and keys with -$lc
ac59b26
End of refactoring, doing tests
d10a5df
Refactor convert.php with new Database methods
ffe91a8
Code refactoring for Database and EQFA
f39d518
Add forgotten "return" for install method
6912ec7
Remove sql cleanValue and fix copy of original data on convert
2d2d9d8
Replace deprecated method fetch() by select()
ba703b6 
Fix bugs in update() method
Fix release info
345e5ea
Fix wrong update-set query
d55e4a7
updateModifyColumn init handle default null
ef452fd 
refactor forgotten Database code
Fix bug getting existing handle.
5f82fc7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexnantel88 alexnantel88

Labels
feedback needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@alexnantel88 @nitriques @beaubbe