#34 nullable c# 8 #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with nullable reference type checks enabled.
…able reference types.
SimonGeering
commented
Aug 10, 2020
SimonGeering
commented
Aug 10, 2020
| public static ConnectionCredentials ToTwitchLib(this TwitchCredentials credentials, IDataProtection dataProtection) | ||
| { | ||
| if (credentials.AuthToken == null) | ||
| throw new System.ArgumentException("Unable to convert null AuthToken", nameof(credentials)); |
There was a problem hiding this comment.
Assumed an exception was better here than just letting the decrypt blow up on an empty byte[]
SimonGeering
commented
Aug 10, 2020
| @@ -45,25 +45,25 @@ public void Disconnect() | |||
| throw new NotImplementedException(); | |||
| } | |||
|
|
|||
| protected virtual void Client_OnLog(object sender, OnLogArgs e) | |||
| protected virtual void Client_OnLog(object? sender, OnLogArgs e) | |||
There was a problem hiding this comment.
All these sender args need to be nullable since twitchlib is not c#8
There was a problem hiding this comment.
*yet
I'll ping LuckyNoS7evin to see if his restructure is going to change that.
SimonGeering
commented
Aug 10, 2020
SimonGeering
commented
Aug 10, 2020
benrick
approved these changes
Aug 10, 2020
| public static ConnectionCredentials ToTwitchLib(this TwitchCredentials credentials, IDataProtection dataProtection) | ||
| { | ||
| if (credentials.AuthToken == null) | ||
| throw new System.ArgumentException("Unable to convert null AuthToken", nameof(credentials)); |
| @@ -45,25 +45,25 @@ public void Disconnect() | |||
| throw new NotImplementedException(); | |||
| } | |||
|
|
|||
| protected virtual void Client_OnLog(object sender, OnLogArgs e) | |||
| protected virtual void Client_OnLog(object? sender, OnLogArgs e) | |||
There was a problem hiding this comment.
*yet
I'll ping LuckyNoS7evin to see if his restructure is going to change that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #34
Please note this is an initial "surgery with a chainsaw" change to get nullable reference types in place with all the code still compiling and the tests working.
While I'm certain some of the chosen defaults could be improved, and there should probably be some unit tests added to drive out such scenarios, the intent here is to have this feature enabled sooner rather than later so that the problem doesn't grow worse in the meantime.