Extract wasm logic from DVCClient into a new wrapper #152
Conversation
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
| SetClientCustomData(customData []byte) error | ||
| Variable(user DVCUser, key string, variableType string) (variable Variable, err error) | ||
| Close() | ||
| } |
There was a problem hiding this comment.
I'm probably going to need to tweak this interface so the serialization of the user and custom data only happens for the WASM flow. I think that's only needed for passing that data safely to WASM?
There was a problem hiding this comment.
only really needed for passing data safely - and performance - but we should be fine moving to just a raw go type for params if we're slowly deprecating WASM fully
client_native.go
Outdated
There was a problem hiding this comment.
Removing these in this PR to make the tests pass cleanly without the native-specific client methods being fully implemented, but I'll add them back again in the next PR.
client_wasm.go
Outdated
There was a problem hiding this comment.
Fun fact - this filename didn't work because suffixing with _wasm tells Go to only compile it when building for the "wasm" arch, which is one of the supported targets of the compiler.
rob-odwyer
force-pushed
the
DVC-6914-extract-wasm-from-client
branch
from
edbf57b
to
fb5033c
Compare
rob-odwyer
changed the title
extract wasm logic from DVCClient into a new wrapper
This refactors the DVCClient so that the WASM and object pool related code is now contained inside a new wrapper type, WASMLocalBucketing.