DVC-6784 - Client Custom Data #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieSinn
force-pushed
the
dvc-6784-clientcustomdata
branch
from
84020d6
to
c032a2a
Compare
* experimenting with a benchmarking action * Changed the trigger * tweaking * upping versions of some of the actions * moar tweaks * fixed thresholds * cleanup * tweaking thresholds * just run the variable evaluation benchmarks
JamieSinn
force-pushed
the
dvc-6784-clientcustomdata
branch
from
c032a2a
to
d6967a4
Compare
JamieSinn
added a commit
that referenced
this pull request
Apr 14, 2023
* DVC-6656 Add benchmark GitHub action (#150) * experimenting with a benchmarking action * Changed the trigger * tweaking * upping versions of some of the actions * moar tweaks * fixed thresholds * cleanup * tweaking thresholds * just run the variable evaluation benchmarks * PlatformData * Client custom data * Return an empty client custom data if none is set * Also fix platformData to allow overriding specific settings per version * Client custom data + version moving around --------- Co-authored-by: Chris Hoefgen <58341173+chris-hoefgen@users.noreply.github.com>
rob-odwyer
pushed a commit
that referenced
this pull request
Apr 14, 2023
* DVC-6656 Add benchmark GitHub action (#150) * experimenting with a benchmarking action * Changed the trigger * tweaking * upping versions of some of the actions * moar tweaks * fixed thresholds * cleanup * tweaking thresholds * just run the variable evaluation benchmarks * PlatformData * Client custom data * Return an empty client custom data if none is set * Also fix platformData to allow overriding specific settings per version * Client custom data + version moving around --------- Co-authored-by: Chris Hoefgen <58341173+chris-hoefgen@users.noreply.github.com>
rob-odwyer
added a commit
that referenced
this pull request
Apr 14, 2023
* unify model types in new api package * move version.go back to package root * variableForUser and basic config handling, still some tests failing * fix typo * sort target distributions by variation ID * run the test harness on all PRs * unify the go.mods again so that test harness can run * DVC-6789 - Config Manager (#153) * Config manager v1 * SDKKey param * Rebase config manager ontop of implementation. Had to move management of the config into the native bucketing lib. * Add etag to storeconfig param on wasmlocalbucketing. * Fix tests from etag change * Remove internal native bucketing handling etag checking. Rely on the parent SDK to handle dedupe * Set key/type on defaulted return * DVC-6784 - Client Custom Data (#156) * DVC-6656 Add benchmark GitHub action (#150) * experimenting with a benchmarking action * Changed the trigger * tweaking * upping versions of some of the actions * moar tweaks * fixed thresholds * cleanup * tweaking thresholds * just run the variable evaluation benchmarks * PlatformData * Client custom data * Return an empty client custom data if none is set * Also fix platformData to allow overriding specific settings per version * Client custom data + version moving around --------- Co-authored-by: Chris Hoefgen <58341173+chris-hoefgen@users.noreply.github.com> * add validator to go.mod * skeleton validation of config * make audiences not a required field in config --------- Co-authored-by: Jamie Sinn <jamie@taplytics.com> Co-authored-by: Jamie Sinn <jamie.sinn@taplytics.com> Co-authored-by: Chris Hoefgen <58341173+chris-hoefgen@users.noreply.github.com>
JamieSinn
added a commit
that referenced
this pull request
Apr 24, 2023
* DVC-6656 Add benchmark GitHub action (#150) * experimenting with a benchmarking action * Changed the trigger * tweaking * upping versions of some of the actions * moar tweaks * fixed thresholds * cleanup * tweaking thresholds * just run the variable evaluation benchmarks * PlatformData * Client custom data * Return an empty client custom data if none is set * Also fix platformData to allow overriding specific settings per version * Client custom data + version moving around --------- Co-authored-by: Chris Hoefgen <58341173+chris-hoefgen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also tweaks private custom data - but the goal here is to be a rough impl with no concerns for threadsafety currently.