Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sealed class generates protected method #8

Closed
impoetk opened this issue Aug 23, 2021 · 2 comments · Fixed by #9
Closed

sealed class generates protected method #8

impoetk opened this issue Aug 23, 2021 · 2 comments · Fixed by #9
Assignees
@Faramoz161
Labels
bug Something isn't working

Comments

@impoetk
Copy link

impoetk commented Aug 23, 2021

When decorating a sealed class with GenerateViewModel, the raise property changed method is generated with "protected" modifier, which generates the following warning:

Warning CS0628 'MainWindowVm.RaisePropertyChanged(PropertyChangedEventArgs)': new protected member declared in sealed type
@Faramoz161 Faramoz161 self-assigned this Aug 24, 2021
@Faramoz161 Faramoz161 added the bug Something isn't working label Aug 24, 2021
@Faramoz161
Copy link
Contributor

Thank you for informing us of this issue. We will fix it as soon as we can.

@Faramoz161 Faramoz161 linked a pull request Aug 25, 2021 that will close this issue
21.1.3 seald class modifires #9
Merged
@Faramoz161 Faramoz161 reopened this Aug 31, 2021
@BelousovSer
Copy link
Contributor

We fixed this issue in v21.1.3. An updated NuGet package is available for download.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Faramoz161 Faramoz161

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

21.1.3 seald class modifires DevExpress/DevExpress.Mvvm.CodeGenerators
3 participants
@impoetk @Faramoz161 @BelousovSer