Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-scheduler): make it possible to drag-drop appointments in MonthView with AllDayPanel plugin #2275

Merged
merged 8 commits into from Aug 28, 2019
Merged

fix(react-scheduler): make it possible to drag-drop appointments in MonthView with AllDayPanel plugin #2275

merged 8 commits into from Aug 28, 2019

Conversation

AryamnovEugeniy
Copy link
Contributor

Fixes #2274

@AryamnovEugeniy
Copy link
Contributor Author

FPR

@AryamnovEugeniy
Copy link
Contributor Author

FPR

ushkal
ushkal reviewed Aug 28, 2019
View reviewed changes
packages/dx-react-scheduler/src/plugins/drag-drop-provider.test.tsx Outdated
@@ -417,6 +417,39 @@ describe('DragDropProvider', () => {
expect(defaultDeps.action.changeAppointment)
.toBeCalledWith({ change: { startDate: new Date('2018-06-25 00:00'), endDate: new Date('2018-06-26 00:00'), allDay: undefined } }, expect.any(Object), expect.any(Object));
});
it('should call cellIndex with array if allDayElementsMeta is an empty object', () => {
const getBoundingClientRect = jest.fn();
getBoundingClientRect.mockImplementationOnce(() => ({ height: 20, top: 20, bottom: 40 }));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not re-define this mock so it's implementation can be inlined to getCellRects at line 427

@AryamnovEugeniy AryamnovEugeniy merged commit 456a423 into DevExpress:master Aug 28, 2019
@AryamnovEugeniy AryamnovEugeniy deleted the impossible_to_dragdrop branch August 28, 2019 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@churkin churkin churkin approved these changes

@MaximKudriavtsev MaximKudriavtsev MaximKudriavtsev approved these changes

@ushkal ushkal ushkal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Impossible to drag-drop appointments in MonthView with AllDayPanel
4 participants
@AryamnovEugeniy @churkin @MaximKudriavtsev @ushkal