Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(react-scheduler): make it possible to drag-drop appointments in MonthView with AllDayPanel plugin #2275

Merged
merged 8 commits into from Aug 28, 2019
Merged

fix(react-scheduler): make it possible to drag-drop appointments in MonthView with AllDayPanel plugin #2275

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3713bc9
Fix
AryamnovEugeniy Aug 27, 2019
5f70330
Add AllDayPanel to featured editing demo
AryamnovEugeniy Aug 27, 2019
9ea93a1
Refactor
AryamnovEugeniy Aug 27, 2019
da39f74
Refactor
AryamnovEugeniy Aug 27, 2019
50f0538
Use ternary operator
AryamnovEugeniy Aug 27, 2019
b57d34e
Apply suggestion
AryamnovEugeniy Aug 27, 2019
8516063
Refactor
AryamnovEugeniy Aug 28, 2019
c1fd808
Merge branch 'master' into impossible_to_dragdrop
MaximKudriavtsev Aug 28, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 2 additions & 4 deletions packages/dx-react-scheduler/src/plugins/drag-drop-provider.tsx
View file
Open in desktop
Expand Up @@ -140,10 +140,8 @@ class DragDropProviderBase extends React.PureComponent<
const tableCellElementsMeta = timeTableElementsMeta;

// AllDayPanel doesn't always exist
let allDayCellsElementsMeta = allDayElementsMeta;
if (!allDayElementsMeta || !allDayElementsMeta.getCellRects) {
allDayCellsElementsMeta = { getCellRects: [] };
}
const allDayCellsElementsMeta = !allDayElementsMeta || !allDayElementsMeta.getCellRects ?
MaximKudriavtsev marked this conversation as resolved.
Show resolved Hide resolved
{ getCellRects: [] } : allDayElementsMeta ;
const timeTableIndex = cellIndex(tableCellElementsMeta.getCellRects, clientOffset);
const allDayIndex = cellIndex(allDayCellsElementsMeta.getCellRects, clientOffset);

Expand Down